buffer: optimize byteLength for common encodings #54342
Merged
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
ronag
commented
Aug 12, 2024
ronag
force-pushed
the
byteLength-o
branch
2 times, most recently
from
1a9f3f9
to
4222999
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54342 +/- ##
==========================================
- Coverage 87.09% 87.09% -0.01%
==========================================
Files 647 647
Lines 181816 181983 +167
Branches 34884 34922 +38
==========================================
+ Hits 158360 158489 +129
- Misses 16764 16779 +15
- Partials 6692 6715 +23
|
benjamingr
approved these changes
Aug 13, 2024
github-actions
bot
removed
the
request-ci
ronag
added
the
author ready
anonrig
approved these changes
Aug 13, 2024
ronag
added
the
commit-queue
lpinca
approved these changes
Aug 13, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 38ad892 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
PR-URL: #54342 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 21, 2024
PR-URL: #54342 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.